linux-kernel - Re: [PATCHv2 46/50] power: Use show_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3067782.Hudzh6pScr@kreacher>
Date:   Wed, 18 Mar 2020 13:54:42 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Dmitry Safonov <dima@...sta.com>
Cc:     linux-kernel@...r.kernel.org,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ingo Molnar <mingo@...nel.org>, Jiri Slaby <jslaby@...e.com>,
        Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCHv2 46/50] power: Use show_stack_loglvl()

On Monday, March 16, 2020 3:39:12 PM CET Dmitry Safonov wrote:
> Aligning with other watchdog messages just before panic - use
> KERN_EMERG.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Len Brown <len.brown@...el.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Dmitry Safonov <dima@...sta.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

or please let me know if I'm expected to take this one.

> ---
>  drivers/base/power/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 0e99a760aebd..9b8450eab02e 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -515,7 +515,7 @@ static void dpm_watchdog_handler(struct timer_list *t)
>  	struct dpm_watchdog *wd = from_timer(wd, t, timer);
>  
>  	dev_emerg(wd->dev, "**** DPM device timeout ****\n");
> -	show_stack(wd->tsk, NULL);
> +	show_stack_loglvl(wd->tsk, NULL, KERN_EMERG);
>  	panic("%s %s: unrecoverable failure\n",
>  		dev_driver_string(wd->dev), dev_name(wd->dev));
>  }
>