linux-kernel - Re: [PATCH v2 16/19] objtool: Implement noinstr validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200318132158.GI20730@hirez.programming.kicks-ass.net>
Date:   Wed, 18 Mar 2020 14:21:58 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     tglx@...utronix.de, jpoimboe@...hat.com
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, mhiramat@...nel.org,
        mbenes@...e.cz, brgerst@...il.com
Subject: Re: [PATCH v2 16/19] objtool: Implement noinstr validation

On Tue, Mar 17, 2020 at 06:02:50PM +0100, Peter Zijlstra wrote:
> +static int validate_vmlinux_functions(struct objtool_file *file)
> +{
> +	struct section *sec;
> +
> +	sec = find_section_by_name(file->elf, ".noinstr.text");
> +	if (!sec) {
> +		WARN("No .noinstr.text section");
> +		return -1;

And that is a little too agressive, seeing how the current x86_64 kernel
does not include it. I made it a silent exit for now, so as not to break
the build (with patch 20/19 added on).

>  	}
>  
> +	return validate_sec_functions(file, sec);
> +}