linux-kernel - Re: [PATCH V3 10/17] perf tools: Save previous sample for LBR stitching approach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <122b2312-c4d2-3b3a-b08a-6a3356f827ea@linux.intel.com>
Date:   Wed, 18 Mar 2020 10:20:14 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, namhyung@...nel.org,
        adrian.hunter@...el.com, mathieu.poirier@...aro.org,
        ravi.bangoria@...ux.ibm.com, alexey.budankov@...ux.intel.com,
        vitaly.slobodskoy@...el.com, pavel.gerasimov@...el.com,
        mpe@...erman.id.au, eranian@...gle.com, ak@...ux.intel.com
Subject: Re: [PATCH V3 10/17] perf tools: Save previous sample for LBR
 stitching approach



On 3/18/2020 8:14 AM, Jiri Olsa wrote:
> On Fri, Mar 13, 2020 at 11:33:12AM -0700, kan.liang@...ux.intel.com wrote:
> 
> SNIP
> 
>> +	struct lbr_stitch	*lbr_stitch;
>>   };
>>   
>>   struct machine;
>> @@ -145,4 +151,14 @@ static inline bool thread__is_filtered(struct thread *thread)
>>   	return false;
>>   }
>>   
>> +static inline void thread__free_stitch_list(struct thread *thread)
>> +{
>> +	struct lbr_stitch *lbr_stitch = thread->lbr_stitch;
>> +
>> +	if (!lbr_stitch)
>> +		return;
>> +
>> +	free(thread->lbr_stitch);
>> +}
> 
> free(thread->lbr_stitch) should be enough
> 

Sure. Will change it in V4.

Thanks,
Kan

> jirka
> 
>> +
>>   #endif	/* __PERF_THREAD_H */
>> -- 
>> 2.17.1
>>
>