linux-kernel - Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be11bc21-4079-f53a-21dc-6121290b9899@infradead.org>
Date:   Wed, 18 Mar 2020 09:27:18 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Zhiqiang Hou <Zhiqiang.Hou@....com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        amurray@...goodpenguin.co.uk, bhelgaas@...gle.com
Subject: Re: [PATCH] PCI: mobiveil: Fix unmet dependency warning for
 PCIE_MOBIVEIL_PLAT

On 3/18/20 3:35 AM, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
>> From: Hou Zhiqiang <Zhiqiang.Hou@....com>
>>
>> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
>> into PCIE_MOBIVEIL_PLAT.
>>
>> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
>>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>>   Selected by [y]:
>>   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
>>
>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
>> ---
>>  drivers/pci/controller/mobiveil/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
> 
> I have applied it to pci/mobiveil for v5.7.

Reported-by: Randy Dunlap <rdunlap@...radead.org>
Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> Thanks,
> Lorenzo
> 
>> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
>> index 7439991ee82c..a62d247018cf 100644
>> --- a/drivers/pci/controller/mobiveil/Kconfig
>> +++ b/drivers/pci/controller/mobiveil/Kconfig
>> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
>>  	bool "Mobiveil AXI PCIe controller"
>>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>>  	depends on OF
>> +	depends on PCI_MSI_IRQ_DOMAIN
>>  	select PCIE_MOBIVEIL_HOST
>>  	help
>>  	  Say Y here if you want to enable support for the Mobiveil AXI PCIe
>> -- 
>> 2.17.1
>>


-- 
~Randy