linux-kernel - Re: [PATCH net] ipv6: don't auto-add link-local address to lag ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfmpSc0yea5-OfE1rnVdErDTeOza=owbL00QQEaH-M-A6Za7g@mail.gmail.com>
Date:   Wed, 18 Mar 2020 14:32:52 -0400
From:   Jarod Wilson <jarod@...hat.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Moshe Levi <moshele@...lanox.com>,
        Marcelo Ricardo Leitner <mleitner@...hat.com>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ipv6: don't auto-add link-local address to lag ports

On Wed, Mar 18, 2020 at 2:02 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> On 3/18/20 7:06 AM, Jarod Wilson wrote:
> > Bonding slave and team port devices should not have link-local addresses
> > automatically added to them, as it can interfere with openvswitch being
> > able to properly add tc ingress.
> >
> > Reported-by: Moshe Levi <moshele@...lanox.com>
> > CC: Marcelo Ricardo Leitner <mleitner@...hat.com>
> > CC: netdev@...r.kernel.org
> > Signed-off-by: Jarod Wilson <jarod@...hat.com>
>
>
> This does not look a net candidate to me, unless the bug has been added recently ?
>
> The absence of Fixes: tag is a red flag for a net submission.
>
> By adding a Fixes: tag, you are doing us a favor, please.

Yeah, wasn't entirely sure on this one. It fixes a problem, but it's
not exactly a new one. A quick look at git history suggests this might
actually be something that technically pre-dates the move to git in
2005, but only really became a problem with some additional far more
recent infrastructure (tc and friends). I can resubmit it as net-next
if that's preferred.

-- 
Jarod Wilson
jarod@...hat.com