linux-kernel - Re: [PATCH v7 0/3] perf report: Support sorting by a given event in group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200318190325.GO11531@kernel.org>
Date:   Wed, 18 Mar 2020 16:03:25 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v7 0/3] perf report: Support sorting by a given event in
 group

Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
> > When performing "perf report --group", it shows the event group information
> > together. By default, the output is sorted by the first event in group.
> > It would be nice for user to select any event for sorting.
> > 
> > The patch 1/3 introduces a new option "--group-sort-idx" to sort the
> > output by the event at the index n in event group.
> > 
> > The patch 2/3 creates a new key K_RELOAD to reload the browser.
> > 
> > The patch 3/3 supports hotkeys in browser to select a event to
> > sort.
> 
> Thanks, applied.

Doesn't work with 'perf top', should, investigating,

- Arnaldo
 
> - Arnaldo
>  
> >  v7:
> >  ---
> >  v6 was posted two months ago and all comments were fixed.
> > 
> >  v7 just rebases to perf/core, no other change.
> > 
> > Jin Yao (3):
> >   perf report: Change sort order by a specified event in group
> >   perf report: Support a new key to reload the browser
> >   perf report: support hotkey to let user select any event for sorting
> > 
> >  tools/perf/Documentation/perf-report.txt |   5 ++
> >  tools/perf/builtin-report.c              |  16 +++-
> >  tools/perf/ui/browsers/hists.c           |  29 ++++++-
> >  tools/perf/ui/hist.c                     | 104 +++++++++++++++++++----
> >  tools/perf/ui/keysyms.h                  |   1 +
> >  tools/perf/util/hist.h                   |   1 +
> >  tools/perf/util/symbol_conf.h            |   1 +
> >  7 files changed, 138 insertions(+), 19 deletions(-)
> > 
> > -- 
> > 2.17.1
> > 
> 
> -- 
> 
> - Arnaldo

-- 

- Arnaldo