linux-kernel - Re: [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002b72cab9896fa5ac76a52e0cb503ff@kernel.org>
Date:   Wed, 18 Mar 2020 19:11:05 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Sungbo Eo <mans0n@...ani.run>
Cc:     linux-oxnas@...ups.io, Linus Walleij <linus.walleij@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH] irqchip/versatile-fpga: Handle chained IRQs properly

On 2020-03-18 18:20, Sungbo Eo wrote:
> Hi Marc,
> 
> On 2020-03-19 02:48, Marc Zyngier wrote:
>> Hi Sungbo,
>> 
>> On 2020-03-18 17:09, Sungbo Eo wrote:
>>> Enclose the chained handler with chained_irq_{enter,exit}(), so that 
>>> the
>>> muxed interrupts get properly acked.
>>> 
>>> This patch also fixes a reboot bug on OX820 SoC, where the jiffies 
>>> timer
>>> interrupt is never acked. The kernel waits a clock tick forever in
>>> calibrate_delay_converge(), which leads to a boot hang.
>> 
>> Nice catch.
>> 
>>> 
>>> Signed-off-by: Sungbo Eo <mans0n@...ani.run>
>>> Cc: Neil Armstrong <narmstrong@...libre.com>
>>> ---
>>>  drivers/irqchip/irq-versatile-fpga.c | 9 ++++++++-
>>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/irqchip/irq-versatile-fpga.c
>>> b/drivers/irqchip/irq-versatile-fpga.c
>>> index 928858dada75..08faab2fec3e 100644
>>> --- a/drivers/irqchip/irq-versatile-fpga.c
>>> +++ b/drivers/irqchip/irq-versatile-fpga.c
>>> @@ -6,6 +6,7 @@
>>>  #include <linux/irq.h>
>>>  #include <linux/io.h>
>>>  #include <linux/irqchip.h>
>>> +#include <linux/irqchip/chained_irq.h>
>>>  #include <linux/irqchip/versatile-fpga.h>
>>>  #include <linux/irqdomain.h>
>>>  #include <linux/module.h>
>>> @@ -68,12 +69,15 @@ static void fpga_irq_unmask(struct irq_data *d)
>>> 
>>>  static void fpga_irq_handle(struct irq_desc *desc)
>>>  {
>>> +    struct irq_chip *chip = irq_desc_get_chip(desc);
>>>      struct fpga_irq_data *f = irq_desc_get_handler_data(desc);
>>>      u32 status = readl(f->base + IRQ_STATUS);
>>> 
>>> +    chained_irq_enter(chip, desc);
>>> +
>> 
>> It's probably not a big deal, but I'm not fond of starting talking to
>> the muxing irqchip before having done the chained_irq_enter() call.
>> 
>> Moving that read here would probably be safer.
> 
> Oops, I missed it. Thanks for pointing it out.
> 
>> 
>>>      if (status == 0) {
>>>          do_bad_IRQ(desc);
>>> -        return;
>>> +        goto out;
>>>      }
>>> 
>>>      do {
>>> @@ -82,6 +86,9 @@ static void fpga_irq_handle(struct irq_desc *desc)
>>>          status &= ~(1 << irq);
>>>          generic_handle_irq(irq_find_mapping(f->domain, irq));
>>>      } while (status);
>>> +
>>> +out:
>>> +    chained_irq_exit(chip, desc);
>>>  }
>>> 
>>>  /*
>> 
>> Otherwise looks good. If you send it again with the above fixed
>> and a Fixes: tag, I'll queue it.
> 
> It seems the handler had been broken from the very beginning. Could
> you give me a hint on how the tag should be like?

Indeed, it has been broken forever. I'm tempted to say:

Fixes: c41b16f8c9d9d ("ARM: integrator/versatile: consolidate FPGA IRQ 
handling code")

even if it probably predates the introduction of the chained_irq_enter() 
helpers.
This will ensure this gets backported to older kernels...

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...