linux-kernel - Re: [PATCH] xen-pciback: fix INTERRUPT_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200319160524.GX18599@mail-itl>
Date:   Thu, 19 Mar 2020 17:05:24 +0100
From:   Marek Marczykowski-Górecki 
        <marmarek@...isiblethingslab.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:     xen-devel@...ts.xenproject.org, Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Roger Pau Monné <roger.pau@...rix.com>,
        Simon Gaiser <simon@...isiblethingslab.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen-pciback: fix INTERRUPT_TYPE_* defines

On Thu, Mar 19, 2020 at 11:07:13AM -0400, Boris Ostrovsky wrote:
> 
> On 3/19/20 12:06 AM, Marek Marczykowski-Górecki wrote:
> > INTERRUPT_TYPE_NONE should be 0,
> 
> 
> Would
> 
>   return ret ?: INTERRUPT_TYPE_NONE
> 
> in xen_pcibk_get_interrupt_type() work?
> 
> 
> I think it's better not to tie macro name to a particular value.

I can do that too. But I'd change INTERRUPT_TYPE_NONE to 0 anyway, as
more logical value (as the value is a bitmask).

> -boris
> 
> 
> >   as it is assumed in
> > xen_pcibk_get_interrupt_type(). Fix the definition, and also shift other
> > values to not leave holes.
> > But also use INTERRUPT_TYPE_NONE in xen_pcibk_get_interrupt_type() to
> > avoid similar confusions in the future.
> > 
> > Fixes: 476878e4b2be ("xen-pciback: optionally allow interrupt enable flag writes")
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>
> > 

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)