lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Mar 2020 09:19:47 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Christian Brauner <christian.brauner@...ntu.com>, "David S. Miller" <davem@...emloft.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Pavel Machek <pavel@....cz>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Stephen Hemminger <stephen@...workplumber.org>, linux-pm@...r.kernel.org, Linux Next Mailing List <linux-next@...r.kernel.org>, Stephen Rothwell <sfr@...b.auug.org.au> Subject: Re: [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() On 3/19/20 7:47 AM, Christian Brauner wrote: > The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different > from the !CONFIG_SYSFS version and thus causes build failurs when > !CONFIG_SYSFS is set. > > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au> Reported-by: Randy Dunlap <rdunlap@...radead.org> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested > Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()") > Signed-off-by: Christian Brauner <christian.brauner@...ntu.com> Thanks. > --- > include/linux/sysfs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > index 9e531ec76274..4beb51009b62 100644 > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -562,8 +562,8 @@ static inline int sysfs_groups_change_owner(struct kobject *kobj, > } > > static inline int sysfs_group_change_owner(struct kobject *kobj, > - const struct attribute_group **groups, > - kuid_t kuid, kgid_t kgid) > + const struct attribute_group *groups, > + kuid_t kuid, kgid_t kgid) > { > return 0; > } > > base-commit: 79e28519ac78dde6d38fe6ea22286af574f5c7db > -- ~Randy
Powered by blists - more mailing lists