linux-kernel - Re: [PATCH net-next 0/7] introduce read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1ba5c47-5a8f-f689-6d33-ec927f4268d8@gmail.com>
Date:   Thu, 19 Mar 2020 09:42:42 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dejin Zheng <zhengdejin5@...il.com>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        tglx@...utronix.de, broonie@...nel.org, corbet@....net,
        mchehab+samsung@...nel.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/7] introduce read_poll_timeout

Le 2020-03-19 à 09:39, Dejin Zheng a écrit :
> This patch sets is introduce read_poll_timeout macro, it is an extension
> of readx_poll_timeout macro. the accessor function op just supports only
> one parameter in the readx_poll_timeout macro, but this macro can
> supports multiple variable parameters for it. so functions like
> phy_read(struct phy_device *phydev, u32 regnum) and
> phy_read_mmd(struct phy_device *phydev, int devad, u32 regnum) can
> use this poll timeout framework.
> 
> the first patch introduce read_poll_timeout macro, and the second patch
> redefined readx_poll_timeout macro by read_poll_timeout(), and the other
> patches are examples using read_poll_timeout macro.
> 
> 
> Dejin Zheng (7):
>   iopoll: introduce read_poll_timeout macro
>   iopoll: redefined readx_poll_timeout macro to simplify the code
>   net: phy: introduce phy_read_mmd_poll_timeout macro
>   net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the
>     code
>   net: phy: aquantia: use phy_read_mmd_poll_timeout() to simplify the
>     code
>   net: phy: introduce phy_read_poll_timeout macro
>   net: phy: use phy_read_poll_timeout() to simplify the code
> 
>  drivers/net/phy/aquantia_main.c | 16 +++++++--------
>  drivers/net/phy/bcm84881.c      | 24 ++++++----------------
>  drivers/net/phy/phy_device.c    | 18 ++++++-----------
>  include/linux/iopoll.h          | 36 ++++++++++++++++++++++++++-------
>  include/linux/phy.h             |  7 +++++++
>  5 files changed, 55 insertions(+), 46 deletions(-)

Your diffstat is positive, so what's the point of doing this? What
problem are you trying to solve?
-- 
Florian