linux-kernel - Re: [PATCH RESEND v6 2/7] mfd: rn5t618: add IRQ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200319182246.27d4809b@kemnade.info>
Date:   Thu, 19 Mar 2020 18:22:46 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     robh+dt@...nel.org, mark.rutland@....com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        stefan@...er.ch, b.galvani@...il.com, phh@....me,
        letux-kernel@...nphoenux.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, linux-iio@...r.kernel.org, jic23@...nel.org
Subject: Re: [PATCH RESEND v6 2/7] mfd: rn5t618: add IRQ support

On Thu, 19 Mar 2020 16:11:49 +0000
Lee Jones <lee.jones@...aro.org> wrote:

> On Fri, 13 Mar 2020, Andreas Kemnade wrote:
[...]
I agree to the other comments.

> > +	if (priv->irq > 0) {  
> 
> There are already have checks in rn5t618_irq_init().
> 
> Just call it regardless.
> 
> > +		if (rn5t618_irq_init(priv))  
> 
> If this returns an error, you should return that error from .probe().
> 
Hmm, that would be a regression. Current users do not specify an interrupt
in the devicetree yet, so the MFD driver would stop working on these devices
completely.
Therefore I think we should keep the existing functionality if there is no
IRQ specified in the devicetree and ignore the error. The new subdevices
are checking the IRQ availability and give error messages and have
reduced functionality.

Regards,
Andreas

Content of type "application/pgp-signature" skipped