linux-kernel - Re: [PATCH -next] PCI: dwc: fix compile err for pcie-tagra194

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200319173710.GA7433@e121166-lin.cambridge.arm.com>
Date:   Thu, 19 Mar 2020 17:37:19 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Qiujun Huang <hqjagain@...il.com>, anders.roxell@...aro.org,
        vidyas@...dia.com
Cc:     jingoohan1@...il.com, gustavo.pimentel@...opsys.com,
        amurray@...goodpenguin.co.uk, bhelgaas@...gle.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PCI: dwc: fix compile err for pcie-tagra194

On Thu, Mar 19, 2020 at 08:36:20PM +0800, Qiujun Huang wrote:
> make allmodconfig
> ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
> 
> need to export the symbols.
> 
> Signed-off-by: Qiujun Huang <hqjagain@...il.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++
>  1 file changed, 3 insertions(+)

I have squashed this in with the original patch.

@Vidya: is this something we missed in the review cycle ? Asking just
to make sure it was not me who made a mistake while merging the code.

Thanks,
Lorenzo

> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 4233c43..60d62ef 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
>  
>  	pci_epc_linkup(epc);
>  }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
>  
>  void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>  {
> @@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>  
>  	pci_epc_init_notify(epc);
>  }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
>  
>  static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
>  				   int flags)
> @@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
>  
>  int dw_pcie_ep_init(struct dw_pcie_ep *ep)
>  {
> -- 
> 1.8.3.1
>