linux-kernel - Re: [PATCH 1/1] x86/mce/amd: Add PPIN support for AMD MCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200319202134.GG13073@zn.tnic>
Date:   Thu, 19 Mar 2020 21:21:34 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Wei Huang <whuang2@....com>
Cc:     Wei Huang <wei.huang2@....com>, linux-kernel@...r.kernel.org,
        tony.luck@...el.com, yazen.ghannam@....com, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, linux-edac@...r.kernel.org,
        x86@...nel.org, smita.koralahallichannabasappa@....com
Subject: Re: [PATCH 1/1] x86/mce/amd: Add PPIN support for AMD MCE

On Thu, Mar 19, 2020 at 03:14:53PM -0500, Wei Huang wrote:
> My proposal is to move mce_amd_ppin_init() function to
> ./arch/x86/kernel/cpu/amd.c and probe X86_FEATURE_AMD_PPIN there. This
> is similar to what early_detect_mem_encrypt() does. Later, mce_setup()
> can use X86_FEATURE_AMD_PPIN directly. Is this approach acceptable?

You can add it to arch/x86/kernel/cpu/mce/amd.c just like
intel_ppin_init() is respectively in .../mce/intel.c, as mce/ is where
this thing is used only. We can move it to kernel/cpu/ later if it turns
out that it is needed for something else.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette