linux-kernel - Re: [PATCH v3 4/9] mm/swapcache: support to handle the value in swapcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAmzW4M2wqA4kJ7rzR7GsoS72krQRZx5i53jZh2uGikmVWLntQ@mail.gmail.com>
Date:   Thu, 19 Mar 2020 15:01:03 +0900
From:   Joonsoo Kim <js1304@...il.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...nel.org>,
        Hugh Dickins <hughd@...gle.com>,
        Minchan Kim <minchan@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Mel Gorman <mgorman@...hsingularity.net>, kernel-team@....com,
        Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v3 4/9] mm/swapcache: support to handle the value in swapcache

2020년 3월 19일 (목) 오전 3:33, Johannes Weiner <hannes@...xchg.org>님이 작성:
>
> On Tue, Mar 17, 2020 at 02:41:52PM +0900, js1304@...il.com wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@....com>
> >
> > Swapcache doesn't handle the value since there is no case using the value.
> > In the following patch, workingset detection for anonymous page will be
> > implemented and it stores the value into the swapcache. So, we need to
> > handle it and this patch implement handling.
>
> "value" is too generic, it's not quite clear what this refers to
> here. "Exceptional entries" or "shadow entries" would be better.

Okay. Will change it.

> > @@ -155,24 +163,33 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry, gfp_t gfp)
> >   * This must be called only on pages that have
> >   * been verified to be in the swap cache.
> >   */
> > -void __delete_from_swap_cache(struct page *page, swp_entry_t entry)
> > +void __delete_from_swap_cache(struct page *page,
> > +                     swp_entry_t entry, void *shadow)
> >  {
> >       struct address_space *address_space = swap_address_space(entry);
> >       int i, nr = hpage_nr_pages(page);
> >       pgoff_t idx = swp_offset(entry);
> >       XA_STATE(xas, &address_space->i_pages, idx);
> >
> > +     /* Do not apply workingset detection for the hugh page */
> > +     if (nr > 1)
> > +             shadow = NULL;
>
> Hm, why is that? Should that be an XXX/TODO item? The comment should
> explain the reason, not necessarily what the code is doing.

It was my TODO. Now, I check the code and find that there is no blocker
for the huge page support. So, I will remove this code and enable the
workingset detection even for the huge page.

> Also, s/hugh/huge/

Okay.

> The rest of the patch looks straight-forward to me.

Thanks.