linux-kernel - Re: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vf+SA7ptRQRxvMtVfN0MzQeQ_AgzAP7fc3eaT5nmsxo_g@mail.gmail.com>
Date:   Thu, 19 Mar 2020 12:24:00 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Rohit Sarkar <rohitsarkar5398@...il.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface

On Thu, Mar 19, 2020 at 8:10 AM Rohit Sarkar <rohitsarkar5398@...il.com> wrote:
>
> The iio debugfs interface provides direct access to read and write device
> registers if debugfs is enabled.

But regmap API provides at least reading facility. Isn't it enough?

...

>  static const struct iio_info mpu_info = {
>         .read_raw = &inv_mpu6050_read_raw,
>         .write_raw = &inv_mpu6050_write_raw,
>         .write_raw_get_fmt = &inv_write_raw_get_fmt,
>         .attrs = &inv_attribute_group,
>         .validate_trigger = inv_mpu6050_validate_trigger,

> +       .debugfs_reg_access = &inv_mpu6050_reg_access

Leaving comma is helpful for future development.

>  };


-- 
With Best Regards,
Andy Shevchenko