linux-kernel - Re: [PATCH v1 3/3] block: set partition read/write policy according to write-protection status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200319102536.GA16757@infradead.org>
Date:   Thu, 19 Mar 2020 03:25:36 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     light.hsieh@...iatek.com
Cc:     ulf.hansson@...aro.org, linux-mediatek@...ts.infradead.org,
        axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuohong.wang@...iatek.com,
        stanley.chu@...iatek.com
Subject: Re: [PATCH v1 3/3] block: set partition read/write policy according
 to write-protection status

On Wed, Mar 04, 2020 at 10:51:14AM +0800, light.hsieh@...iatek.com wrote:
> From: Light Hsieh <light.hsieh@...iatek.com>
> 
> For storage device with write-protection support, e.g. eMMC, register
> check_disk_range_wp() in struct block_device_operations for checking
> write-protection status. When creating block device for a partition, set
> read/write policy according to result of check_disk_range_wp() operation
> (if registered).
> 
> Without this patch, ro attribute is not set for created block device of
> write-protected partition. User perform asynchronous buffered write to
> such partition won't get immediate error and therefore he won't be awared
> that write is not actually performed.
> With this patch, ro attribute is set for created block device of
> write-protected partition. User perform asynchronous buffered write to
> such partition will get immediate error and therefore he will be awared.

NAK.  This is complete BS.  Partitions are a complete software concepts
and idiotic features like a range read only should not interact with it
at all (and I urge all Linux users to never make use of such broken
features, so the less support we have for them, the better).