linux-kernel - Re: [PATCH net-next] liquidio: remove set but not used variable 's'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200319121035.GO126814@unreal>
Date:   Thu, 19 Mar 2020 14:10:35 +0200
From:   Leon Romanovsky <leonro@...lanox.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Derek Chickles <dchickles@...vell.com>,
        "David S . Miller" <davem@...emloft.net>,
        Satanand Burla <sburla@...vell.com>,
        Felix Manlunas <fmanlunas@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH net-next] liquidio: remove set but not used variable 's'

On Thu, Mar 19, 2020 at 12:07:43PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_chip_specific_setup':
> drivers/net/ethernet/cavium/liquidio/lio_main.c:1378:8: warning:
>  variable 's' set but not used [-Wunused-but-set-variable]
>
> It's not used since commit b6334be64d6f ("net/liquidio: Delete driver version assignment")
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 -----
>  1 file changed, 5 deletions(-)
>

I'm sorry for missing this warning.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>