linux-kernel - Re: [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99196b17-24fb-8990-2d21-c459d2321747@suse.cz>
Date:   Thu, 19 Mar 2020 13:32:53 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     js1304@...il.com, Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Minchan Kim <minchan@...nel.org>,
        Mel Gorman <mgorman@...hsingularity.net>, kernel-team@....com,
        Ye Xiaolong <xiaolong.ye@...el.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and
 high_zoneidx

On 3/18/20 4:32 AM, js1304@...il.com wrote:
> From: Joonsoo Kim <iamjoonsoo.kim@....com>
> 
> classzone_idx is just different name for high_zoneidx now.
> So, integrate them and add some comment to struct alloc_context
> in order to reduce future confusion about the meaning of this variable.
> 
> In addition to integration, this patch also renames high_zoneidx
> to highest_zoneidx since it represents more precise meaning.

2 years ago I suggested max_zone_idx.
Not insisting, but perhaps max_zoneidx would simply be shorter than
highest_zoneidx, while saying the same thing?

Also I wonder if we still need the accessor ac_classzone_idx() (before rename),
or just replace it with ac->highest_zoneidx (or whatever the final name is)
instead of renaming it?

Thanks!
Vlastimil