linux-kernel - Re: [PATCH 2/7] dt-bindings: usb: dwc3: Add a gpio-usb-connector example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158458013177.152100.17920784952083533825@swboyd.mtv.corp.google.com>
Date:   Wed, 18 Mar 2020 18:08:51 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, balbi@...nel.org,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        bjorn.andersson@...aro.org, jackp@...eaurora.org, robh@...nel.org,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: usb: dwc3: Add a gpio-usb-connector example

Quoting Bryan O'Donoghue (2020-03-11 12:14:56)
> A USB connector should be a child node of the USB controller
> connector/usb-connector.txt. This patch adds an example of how to do this
> to the dwc3 binding descriptions.

I read that as a child of the USB interface controller, which is not the
same as the USB controller. For example, we're talking about having the
usb connector be a child of the EC on ChromeOS devices because that
manages the connector

> 
> It is necessary to declare a connector as a child-node of a USB controller
> for role-switching to work, so this example should be helpful to others
> implementing that.

Maybe it should be a virtual node at the root of the DT if it's GPIO
controlled? And then the phy can be connected to the usb connector
through the graph binding.

> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: linux-usb@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Acked-by: Felipe Balbi <balbi@...nel.org>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Tested-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 66780a47ad85..4e1e4afccee6 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -121,4 +121,12 @@ dwc3@...30000 {
>         interrupts = <0 92 4>
>         usb-phy = <&usb2_phy>, <&usb3,phy>;

Weird that there's a comma here        ^

Not a problem with this patch, just noticing it while reading the diff.

>         snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> +
> +       usb_con: connector {
> +               compatible = "gpio-usb-b-connector";
> +               id-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>;
> +               vbus-supply = <&usb3_vbus_reg>;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&usb3_id_pin>, <&usb3_vbus_pin>;
> +       };