linux-kernel - Re: [PATCH v7 0/3] perf report: Support sorting by a given event in group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Mar 2020 09:42:42 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v7 0/3] perf report: Support sorting by a given event in
 group



On 3/19/2020 3:08 AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 18, 2020 at 04:03:25PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Mar 18, 2020 at 04:01:16PM -0300, Arnaldo Carvalho de Melo escreveu:
>>> Em Thu, Feb 20, 2020 at 09:36:13AM +0800, Jin Yao escreveu:
>>>> When performing "perf report --group", it shows the event group information
>>>> together. By default, the output is sorted by the first event in group.
>>>> It would be nice for user to select any event for sorting.
>>>>
>>>> The patch 1/3 introduces a new option "--group-sort-idx" to sort the
>>>> output by the event at the index n in event group.
>>>>
>>>> The patch 2/3 creates a new key K_RELOAD to reload the browser.
>>>>
>>>> The patch 3/3 supports hotkeys in browser to select a event to
>>>> sort.
>>>
>>> Thanks, applied.
>>
>> Doesn't work with 'perf top', should, investigating,
> 
> So needs a bit of work, but is doable and would be a great addition,
> since we do support:
> 
>    # perf top --group -e instructions,cycles,cache-misses
> 
> And we should strive to make 'perf top' to be a perf.data-less, dynamic
> version of 'perf record + perf report'.
> 
> Can you please take a look at supporting this? And that --group-sort-idx
> too,
> 
> I'll push my perf/core branch after a few tests,
> 
> Thanks,
> 
> - Arnaldo
> 

I will check that.

Thanks
Jin Yao