linux-kernel - Re: [PATCH v2 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas digital multiphase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200320030242.GA2413@roeck-us.net>
Date:   Thu, 19 Mar 2020 20:02:42 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Grant Peltier <grantpeltier93@...il.com>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        adam.vaughn.xh@...esas.com
Subject: Re: [PATCH v2 1/2] hwmon: (pmbus) add support for 2nd Gen Renesas
 digital multiphase

On Thu, Mar 19, 2020 at 10:49:50AM -0500, Grant Peltier wrote:
> Extend the isl68137 driver to provide support for 2nd generation Renesas
> digital multiphase voltage regulators.
> 
> Signed-off-by: Grant Peltier <grantpeltier93@...il.com>

I hate to (have to) say that, but there are lots of checkpatch errors and
warnings in this patch.

total: 7 errors, 4 warnings, 182 lines checked

That is really unnecessary. Please fix and resubmit.

Thanks,
Guenter