lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Mar 2020 21:27:41 +0100 From: Bernd Edlinger <bernd.edlinger@...mail.de> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kirill Tkhai <ktkhai@...tuozzo.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Christian Brauner <christian.brauner@...ntu.com>, Kees Cook <keescook@...omium.org>, Jann Horn <jannh@...gle.com>, Jonathan Corbet <corbet@....net>, Alexander Viro <viro@...iv.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, Alexey Dobriyan <adobriyan@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Oleg Nesterov <oleg@...hat.com>, Frederic Weisbecker <frederic@...nel.org>, Andrei Vagin <avagin@...il.com>, Ingo Molnar <mingo@...nel.org>, "Peter Zijlstra (Intel)" <peterz@...radead.org>, Yuyang Du <duyuyang@...il.com>, David Hildenbrand <david@...hat.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Anshuman Khandual <anshuman.khandual@....com>, David Howells <dhowells@...hat.com>, James Morris <jamorris@...ux.microsoft.com>, Shakeel Butt <shakeelb@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>, Christian Kellner <christian@...lner.me>, Andrea Arcangeli <aarcange@...hat.com>, Aleksa Sarai <cyphar@...har.com>, "Dmitry V. Levin" <ldv@...linux.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>, "linux-api@...r.kernel.org" <linux-api@...r.kernel.org> Subject: [PATCH v6 12/16] proc: io_accounting: Use new infrastructure to fix deadlocks in execve This changes do_io_accounting to use the new exec_update_mutex instead of cred_guard_mutex. This fixes possible deadlocks when the trace is accessing /proc/$pid/io for instance. This should be safe, as the credentials are only used for reading. Signed-off-by: Bernd Edlinger <bernd.edlinger@...mail.de> --- fs/proc/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index fed76abf..6b13fc4 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2861,7 +2861,7 @@ static int do_io_accounting(struct task_struct *task, struct seq_file *m, int wh unsigned long flags; int result; - result = mutex_lock_killable(&task->signal->cred_guard_mutex); + result = mutex_lock_killable(&task->signal->exec_update_mutex); if (result) return result; @@ -2897,7 +2897,7 @@ static int do_io_accounting(struct task_struct *task, struct seq_file *m, int wh result = 0; out_unlock: - mutex_unlock(&task->signal->cred_guard_mutex); + mutex_unlock(&task->signal->exec_update_mutex); return result; } -- 1.9.1
Powered by blists - more mailing lists