linux-kernel - Re: [PATCH v3 1/5] dt-bindings: phy: Document Samsung UFS PHY bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Mar 2020 06:08:15 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        "robh+dt" <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-scsi@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>,
        Avri Altman <avri.altman@....com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Can Guo <cang@...eaurora.org>,
        linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: phy: Document Samsung UFS PHY bindings

Hi Rob

On Fri, Mar 20, 2020 at 5:53 AM Rob Herring <robh@...nel.org> wrote:
>
> On Thu, 19 Mar 2020 20:30:27 +0530, Alim Akhtar wrote:
> > This patch documents Samsung UFS PHY device tree bindings
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
> > ---
> >  .../bindings/phy/samsung,ufs-phy.yaml         | 62 +++++++++++++++++++
> >  1 file changed, 62 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dt.yaml: example-0: 'ufs-phy@...5571800' does not match any of the regexes: '.*-names$', '.*-supply$', '^#.*-cells$', '^#[a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}$', '^[a-zA-Z][a-zA-Z0-9,+\\-._]{0,63}@[0-9a-fA-F]+(,[0-9a-fA-F]+)*$', '^__.*__$', 'pinctrl-[0-9]+'
>
> See https://patchwork.ozlabs.org/patch/1258280
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
Yes, I did ran 'make dt_binding_check' and saw no errors,

---
/work/linux $ make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
scripts/kconfig/conf  --syncconfig Kconfig
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTCC  scripts/dtc/yamltree.o
  HOSTLD  scripts/dtc/dtc
  CHKDT   Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
  SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
  DTC     Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dt.yaml
~/work/linux $ dtc --version
Version: DTC 1.5.0-g62cb4ad2
---------------
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
Thanks for pointing this out, I will upgrade and re-run and re-submit.

> Please check and re-submit.



-- 
Regards,
Alim