linux-kernel - Re: [PATCH v2 04/32] KVM: nVMX: Invalidate all L2 roots when emulating INVVPID without EPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200320041102.GG11305@linux.intel.com>
Date:   Thu, 19 Mar 2020 21:11:02 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ben Gardon <bgardon@...gle.com>,
        Junaid Shahid <junaids@...gle.com>,
        Liran Alon <liran.alon@...cle.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        John Haxby <john.haxby@...cle.com>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH v2 04/32] KVM: nVMX: Invalidate all L2 roots when
 emulating INVVPID without EPT

On Mon, Mar 16, 2020 at 09:52:10PM -0700, Sean Christopherson wrote:
> From: Junaid Shahid <junaids@...gle.com>
> 
> Free all L2 (guest_mmu) roots when emulating INVVPID for L1 and EPT is
> disabled, as outstanding changes to the page tables managed by L1 need
> to be recognized.
> 
> Similar to handle_invpcid() and handle_invept(), rely on
> kvm_mmu_free_roots() to do a remote TLB flush if necessary, e.g. if L1
> has never entered L2 then there is nothing to be done.
> 
> Fixes: 5c614b3583e7b ("KVM: nVMX: nested VPID emulation")
> Signed-off-by: Junaid Shahid <junaids@...gle.com>
> [sean: ported to upstream KVM, reworded the comment and changelog]
> Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
> ---
>  arch/x86/kvm/vmx/nested.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 9624cea4ed9f..50bb7d8862aa 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -5250,6 +5250,17 @@ static int handle_invvpid(struct kvm_vcpu *vcpu)
>  		return kvm_skip_emulated_instruction(vcpu);
>  	}
>  
> +	/*
> +	 * Sync L2's shadow page tables if EPT is disabled, L1 is effectively
> +	 * invalidating linear mappings for L2 (tagged with L2's VPID).  Sync
> +	 * all roots as VPIDs are not tracked in the MMU role.
> +	 *
> +	 * TODO: sync only the affected SPTEs for INVDIVIDUAL_ADDR.
> +	 */
> +	if (!enable_ept)
> +		kvm_mmu_free_roots(vcpu, &vcpu->arch.guest_mmu,

Aha!  This is wrong.  guest_mmu is only used if EPT is enabled.  The silver
lining is that I have confirmed that this code is needed and works as
intended (when the correct mmu is nuked).

> +				   KVM_MMU_ROOTS_ALL);
> +
>  	return nested_vmx_succeed(vcpu);
>  }
>  
> -- 
> 2.24.1
>