linux-kernel - Re: [PATCH bpf-next 2/2] bpf: tcp: Make tcp_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3fb3edd-f853-324f-ad32-04e0d5b0239b@fb.com>
Date:   Thu, 19 Mar 2020 21:23:47 -0700
From:   Yonghong Song <yhs@...com>
To:     YueHaibing <yuehaibing@...wei.com>, <lmb@...udflare.com>,
        <daniel@...earbox.net>, <jakub@...udflare.com>,
        <john.fastabend@...il.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <bpf@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <andrii.nakryiko@...il.com>
Subject: Re: [PATCH bpf-next 2/2] bpf: tcp: Make tcp_bpf_recvmsg static



On 3/19/20 7:34 PM, YueHaibing wrote:
> After commit f747632b608f ("bpf: sockmap: Move generic sockmap
> hooks from BPF TCP"), tcp_bpf_recvmsg() is not used out of
> tcp_bpf.c, so make it static and remove it from tcp.h. Also move
> it to BPF_STREAM_PARSER #ifdef to fix unused function warnings.
>
Fixes: f747632b608f ("bpf: sockmap: Move generic sockmap hooks from BPF 
TCP")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   include/net/tcp.h  |   2 -
>   net/ipv4/tcp_bpf.c | 124 ++++++++++++++++++++++-----------------------
>   2 files changed, 62 insertions(+), 64 deletions(-)

Other than the above fixes,
Acked-by: Yonghong Song <yhs@...com>