linux-kernel - Re: [PATCH v4 0/5] module autoloading fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200320052819.GB1315@sol.localdomain>
Date:   Thu, 19 Mar 2020 22:28:19 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-fsdevel@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeff Vander Stoep <jeffv@...gle.com>,
        Jessica Yu <jeyu@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        NeilBrown <neilb@...e.com>
Subject: Re: [PATCH v4 0/5] module autoloading fixes and cleanups

On Wed, Mar 18, 2020 at 04:05:10PM -0700, Eric Biggers wrote:
> This series fixes a bug where request_module() was reporting success to
> kernel code when module autoloading had been completely disabled via
> 'echo > /proc/sys/kernel/modprobe'.
> 
> It also addresses the issues raised on the original thread
> (https://lkml.kernel.org/lkml/20200310223731.126894-1-ebiggers@kernel.org/T/#u)
> by documenting the modprobe sysctl, adding a self-test for the empty
> path case, and downgrading a user-reachable WARN_ONCE().
> 
> Changed since v3:
>   - Added Fixes tag to the fs/filesystems.c patch, and mentioned why the
>     warning is continued to be printed once only.
> 
> Changed since v2:
>   - Adjusted the new documentation to avoid implicitly bringing up
>     module aliases, which are a more complex topic.
>   - Split the selftest patch into two patches, one to fix the test
>     numbering bug and one to add the new tests.
> 
> Changed since v1:
>   - Added patches to address the other issues raised on the thread.

It seems that people are relatively happy with this patch series now.
Andrew, will you be taking it through -mm?  I don't see any better place.

Thanks,

- Eric