linux-kernel - Re: [alsa-devel] [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC: sgtl5000: Fix of unmute outputs on probe"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af99c9abd9c2aec6a074fb05310c56b780725ebd.camel@toradex.com>
Date:   Fri, 20 Mar 2020 07:26:00 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "broonie@...nel.org" <broonie@...nel.org>,
        "tharvey@...eworks.com" <tharvey@...eworks.com>,
        Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
CC:     "alison.wang@....com" <alison.wang@....com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "festevam@...il.com" <festevam@...il.com>,
        Igor Opanyuk <igor.opanyuk@...adex.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [alsa-devel] [EXT] Re: [PATCH] ASoC: sgtl5000: Revert "ASoC:
 sgtl5000: Fix of unmute outputs on probe"

Hi Tim

On Thu, 2020-03-19 at 13:49 -0700, Tim Harvey wrote:
> On Thu, Dec 12, 2019 at 4:24 AM Mark Brown <broonie@...nel.org>
> wrote:
> > On Thu, Dec 12, 2019 at 10:46:31AM +0000, Alison Wang wrote:
> > 
> > > We tested this standard solution using gstreamer and standard
> > > ALSA
> > > tools like aplay, arecord and all these tools unmute needed
> > > blocks
> > > successfully.
> > > [Alison Wang] I am using aplay. Do you mean I need to add some
> > > parameters for aplay or others to unmute the outputs?
> > 
> > Use amixer.
> 
> Marc / Oleksandr,
> 
> I can't seem to find the original patch in my mailbox for 631bc8f:
> ('ASoC: sgtl5000: Fix of unmute outputs on probe')

I forwarded you that one again. OK?

> however I find it
> breaks sgtl5000 audio output on the Gateworks boards which is still
> broken on 5.6-rc6.

What exactly do you mean by "breaks"? Isn't it that you just need to
unmute stuff e.g. using amixer or using a proper updated asound.state
file with default states for your controls?

> Was there some follow-up patches that haven't made
> it into mainline yet regarding this?

I don't think so. It all works perfectly, not?

> The response above indicates maybe there was an additional ALSA
> control perhaps added as a resolution but I don't see any differences
> there.

Not that I am aware of, no.

> Best Regards,
> 
> Tim

Cheers

Marcel