linux-kernel - Re: [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word "error" for message "Failed to register device with error %d"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d40a0b9434042f51c4b21cd48db7ac55522db5a.camel@perches.com>
Date:   Fri, 20 Mar 2020 01:52:10 -0700
From:   Joe Perches <joe@...ches.com>
To:     "she90122 ." <she90122@...il.com>
Cc:     Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Amy.Shih" <Amy.Shih@...antech.com.tw>,
        "Oakley.Ding" <Oakley.Ding@...antech.com.tw>
Subject: Re: [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word
 "error" for message "Failed to register device with error %d"

On Fri, 2020-03-20 at 16:26 +0800, she90122 . wrote:
> From: Amy Shih <amy.shih@...antech.com.tw>
> 
> Fix the log level from "KERN_ERR" to "KERN_INFO" and remove the word
> "error" for message "Failed to register device with error %d", since
> it is not the error message but the information to notice the user.
> 
> Signed-off-by: Amy Shih <amy.shih@...antech.com.tw>
> ---
> Changes in v2:
> - Remove the word "error" from output message.
> ---
>  drivers/edac/pnd2_edac.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index
> 933f772..399da3e 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
> 
>   rc = pnd2_probe();
>   if (rc < 0) {
> - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
> + pnd2_printk(KERN_INFO,
> +     "Failed to register device - %d.\n", rc);
>   return rc;
>   }

This will not apply as it's whitespace damaged.

Another possibility would be to use the new %pe extension.
---
 drivers/edac/pnd2_edac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 933f77..370f219 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
 
 	rc = pnd2_probe();
 	if (rc < 0) {
-		pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+		pnd2_printk(KERN_INFO, "Failed to register device - %pe\n",
+			    ERR_PTR(rc));
 		return rc;
 	}