linux-kernel - Re: [PATCH v2] PCI: dwc: fix compile err for pcie-tagra194

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9791f44-b257-3851-fd0c-144fad8e7719@nvidia.com>
Date:   Fri, 20 Mar 2020 14:45:47 +0530
From:   Vidya Sagar <vidyas@...dia.com>
To:     Qiujun Huang <hqjagain@...il.com>, <lorenzo.pieralisi@....com>,
        <anders.roxell@...aro.org>
CC:     <jingoohan1@...il.com>, <gustavo.pimentel@...opsys.com>,
        <amurray@...goodpenguin.co.uk>, <bhelgaas@...gle.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] PCI: dwc: fix compile err for pcie-tagra194



On 3/20/2020 11:54 AM, Qiujun Huang wrote:
> External email: Use caution opening links or attachments
> 
> 
> make allmodconfig
> ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
> 
> need to export the symbols.
> 
> Signed-off-by: Qiujun Huang <hqjagain@...il.com>
> ---
>   drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 4233c43..1cdcbd1 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
> 
>          pci_epc_linkup(epc);
>   }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
> 
>   void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>   {
> @@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
> 
>          pci_epc_init_notify(epc);
>   }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
> 
>   static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
>                                     int flags)
> @@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
> 
>          return 0;
>   }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
> 
>   int dw_pcie_ep_init(struct dw_pcie_ep *ep)
>   {
> @@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> 
>          return dw_pcie_ep_init_complete(ep);
>   }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init);
> --
> 1.8.3.1
> 

Thanks for the change Qiujun.
Reviewed-by: Vidya Sagar <vidyas@...dia.com>
Tested-by: Vidya Sagar <vidyas@...dia.com>