linux-kernel - Re: [PATCH v3 3/8] drivers/base/memory: store mapping between MMOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <166f7f03-eda9-00a8-bd18-128898526313@redhat.com>
Date:   Fri, 20 Mar 2020 10:50:56 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linuxppc-dev@...ts.ozlabs.org, linux-hyperv@...r.kernel.org,
        Wei Yang <richard.weiyang@...il.com>,
        Michal Hocko <mhocko@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...nel.org>,
        Oscar Salvador <osalvador@...e.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v3 3/8] drivers/base/memory: store mapping between MMOP_*
 and string in an array

On 20.03.20 08:36, Baoquan He wrote:
> On 03/19/20 at 02:12pm, David Hildenbrand wrote:
>> Let's use a simple array which we can reuse soon. While at it, move the
>> string->mmop conversion out of the device hotplug lock.
>>
>> Reviewed-by: Wei Yang <richard.weiyang@...il.com>
>> Acked-by: Michal Hocko <mhocko@...e.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Michal Hocko <mhocko@...nel.org>
>> Cc: Oscar Salvador <osalvador@...e.de>
>> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
>> Cc: Baoquan He <bhe@...hat.com>
>> Cc: Wei Yang <richard.weiyang@...il.com>
>> Signed-off-by: David Hildenbrand <david@...hat.com>
>> ---
>>  drivers/base/memory.c | 38 +++++++++++++++++++++++---------------
>>  1 file changed, 23 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>> index e7e77cafef80..8a7f29c0bf97 100644
>> --- a/drivers/base/memory.c
>> +++ b/drivers/base/memory.c
>> @@ -28,6 +28,24 @@
>>  
>>  #define MEMORY_CLASS_NAME	"memory"
>>  
>> +static const char *const online_type_to_str[] = {
>> +	[MMOP_OFFLINE] = "offline",
>> +	[MMOP_ONLINE] = "online",
>> +	[MMOP_ONLINE_KERNEL] = "online_kernel",
>> +	[MMOP_ONLINE_MOVABLE] = "online_movable",
>> +};
>> +
>> +static int memhp_online_type_from_str(const char *str)
>> +{
>> +	int i;
> 
> I would change it as: 
> 
> 	for (int i = 0; i < ARRAY_SIZE(online_type_to_str); i++) {
> 

That's not allowed by the C90 standard (and -std=gnu89).

$ gcc main.c -std=gnu89
main.c: In function 'main':
main.c:3:2: error: 'for' loop initial declarations are only allowed in
C99 or C11 mode
    3 |  for (int i = 0; i < 8; i++) {
      |  ^~~

One of the reasons why
	git grep "for (int "

will result in very little hits (IOW, only 5 in driver code only).

-- 
Thanks,

David / dhildenb