linux-kernel - Re: [PATCH v2] xen-pciback: fix INTERRUPT_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46cf0d25-11bc-e580-fe30-9898551c28e2@oracle.com>
Date:   Thu, 19 Mar 2020 21:21:38 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Marek Marczykowski-Górecki 
        <marmarek@...isiblethingslab.com>, xen-devel@...ts.xenproject.org
Cc:     Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Simon Gaiser <simon@...isiblethingslab.com>,
        Roger Pau Monné <roger.pau@...rix.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] xen-pciback: fix INTERRUPT_TYPE_* defines


On 3/19/20 11:09 PM, Marek Marczykowski-Górecki wrote:
> xen_pcibk_get_interrupt_type() assumes INTERRUPT_TYPE_NONE being 0
> (initialize ret to 0 and return as INTERRUPT_TYPE_NONE).
> Fix the definition to make INTERRUPT_TYPE_NONE really 0, and also shift
> other values to not leave holes.
> But also, do not assume INTERRUPT_TYPE_NONE being 0 anymore to avoid
> similar confusions in the future.
>
> Fixes: 476878e4b2be ("xen-pciback: optionally allow interrupt enable flag writes")
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@...isiblethingslab.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>