linux-kernel - Re: [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e67eefc91d4f54a5fbf64be9e6bee94680461b60.camel@perches.com>
Date:   Thu, 19 Mar 2020 18:54:34 -0700
From:   Joe Perches <joe@...ches.com>
To:     Amy.Shih@...antech.com.tw, she90122@...il.com
Cc:     Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        oakley.ding@...antech.com.tw
Subject: Re: [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to
 register device with error %d"

On Tue, 2020-03-17 at 06:28 +0000, Amy.Shih@...antech.com.tw wrote:
> From: Amy Shih <amy.shih@...antech.com.tw>
> 
> Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to
> register device with error %d", since it is not the error message but
> the information to notice the user.
[]
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
[]
> @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
>  
>  	rc = pnd2_probe();
>  	if (rc < 0) {
> -		pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
> +		pnd2_printk(KERN_INFO,
> +			    "Failed to register device with error %d.\n", rc);

So there's no need to use the word "error"
in the output message either.

	"Failed to register device - %d\n", rc

would be enough.