linux-kernel - Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200320135436.GA23532@zn.tnic>
Date:   Fri, 20 Mar 2020 14:54:36 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Daniel Drake <drake@...lessm.com>
Cc:     Jian-Hong Pan <jian-hong@...lessm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>, x86@...nel.org,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        linux-efi@...r.kernel.org,
        Linux Upstreaming Team <linux@...lessm.com>
Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer
 TravelMate X514-51T"

On Fri, Mar 20, 2020 at 08:37:54PM +0800, Daniel Drake wrote:
> Based on that I was considering that the patch could be reverted for
> cleanliness/ At the same time, I do not have strong feelings on this,
> no issues if the quirk is left in place.

Oh, I'd take the revert on cleanliness grounds any day of the week. But
if that broken fw has snuck out and someone comes and complains that it
wouldn't reboot properly, then I'd have to revert the revert.

And looking at that reboot_dmi_table[] of who's who of broken BIOSes,
one entry less ain't gonna make it prettier.

:-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette