linux-kernel - Re: [PATCH] sched: Remove unused last_load_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Mar 2020 14:57:57 +0100
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Vincent Donnefort <vincent.donnefort@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Valentin Schneider <valentin.schneider@....com>
Subject: Re: [PATCH] sched: Remove unused last_load_update_tick rq member

On Fri, 20 Mar 2020 at 14:44, Dietmar Eggemann <dietmar.eggemann@....com> wrote:
>
> + Vincent Guittot

Thanks Dietmar

>
> On 20.03.20 14:21, vincent.donnefort@....com wrote:
> > From: Vincent Donnefort <vincent.donnefort@....com>
> >
> > The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
> > code") eliminated the use case for rq->last_load_update_tick. Removing
> > it.
> >
> > Signed-off-by: Vincent Donnefort <vincent.donnefort@....com>

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 1a9983d..c41ee26 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6685,7 +6685,6 @@ void __init sched_init(void)
> >
> >               rq_attach_root(rq, &def_root_domain);
> >  #ifdef CONFIG_NO_HZ_COMMON
> > -             rq->last_load_update_tick = jiffies;
> >               rq->last_blocked_load_update_tick = jiffies;
> >               atomic_set(&rq->nohz_flags, 0);
> >  #endif
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index 9ea6478..6e14fad 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -860,7 +860,6 @@ struct rq {
> >  #endif
> >  #ifdef CONFIG_NO_HZ_COMMON
> >  #ifdef CONFIG_SMP
> > -     unsigned long           last_load_update_tick;
> >       unsigned long           last_blocked_load_update_tick;
> >       unsigned int            has_blocked_load;
> >  #endif /* CONFIG_SMP */
>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@....com>