linux-kernel - Re: [PATCH] arm/ftrace: Remove duplicate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200320101159.60037586@gandalf.local.home>
Date:   Fri, 20 Mar 2020 10:11:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     guoren@...nel.org
Cc:     mingo@...hat.co, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH] arm/ftrace: Remove duplicate function

On Fri, 20 Mar 2020 14:53:40 +0800
guoren@...nel.org wrote:

> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> There is no arch implementation of ftrace_arch_code_modify_prepare in arm,
> so just use the __weak one in kernel/trace/ftrace.c.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> 
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> ---
>  arch/arm/kernel/ftrace.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm/kernel/ftrace.c b/arch/arm/kernel/ftrace.c
> index 10499d44964a..f66ade28eb8a 100644
> --- a/arch/arm/kernel/ftrace.c
> +++ b/arch/arm/kernel/ftrace.c
> @@ -56,11 +56,6 @@ static unsigned long adjust_address(struct dyn_ftrace *rec, unsigned long addr)
>  	return addr;
>  }
>  
> -int ftrace_arch_code_modify_prepare(void)
> -{
> -	return 0;
> -}
> -
>  int ftrace_arch_code_modify_post_process(void)
>  {
>  	/* Make sure any TLB misses during machine stop are cleared. */