linux-kernel - Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d60faa5-2749-0581-7ee5-252f15b0e9cf@gmail.com>
Date:   Fri, 20 Mar 2020 17:25:04 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>, ldewangan@...dia.com,
        jonathanh@...dia.com, dan.j.williams@...el.com, vkoul@...nel.org,
        thierry.reding@...il.com, swarren@...dotorg.org
Cc:     dmaengine@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as
 __maybe_unused

20.03.2020 10:13, YueHaibing пишет:
> When CONFIG_PM is disabled, gcc warning this:
> 
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
> 
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
> 
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
...

Looks good, thank you:

Reviewed-by: Dmitry Osipenko <digetx@...il.com>