linux-kernel - Re: Build error on 5.5.10 after activating v4l in .config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200320161301.36866c31@coco.lan>
Date:   Fri, 20 Mar 2020 16:13:01 +0100
From:   Mauro Carvalho Chehab <mchehab@...nel.org>
To:     Martin Knoblauch <knobi@...bisoft.de>
Cc:     linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: Build error on 5.5.10 after activating v4l in .config

Em Fri, 20 Mar 2020 15:56:16 +0100
Martin Knoblauch <knobi@...bisoft.de> escreveu:

> Hi, (sesending without attachment)
> 
>  today I tried to build 5.5.10 based on a working 5.5.6 configuration. I
> also enabled v4l in the configuration using menuconfig. This resulted in
> the following build error:
> 
>   AS      arch/x86/boot/compressed/efi_thunk_64.o
>   CC      arch/x86/boot/compressed/misc.o
>   XZKERN  arch/x86/boot/compressed/vmlinux.bin.xz
> ERROR: "__devm_regmap_init_i2c" [drivers/media/i2c/tvp5150.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1282: modules] Error 2
> make: *** Waiting for unfinished jobs....
> 
> After some searching the universal support tool, I applied the following
> patch:
> 
> --- ./drivers/media/i2c/Kconfig-orig 2020-03-18 13:57:30.288639392 +0100
> +++ ./drivers/media/i2c/Kconfig 2020-03-18 16:44:03.938384192 +0100
> @@ -378,6 +378,7 @@
>  config VIDEO_TVP5150
>   tristate "Texas Instruments TVP5150 video decoder"
>   depends on VIDEO_V4L2 && I2C
> + select REGMAP_I2C
>   select V4L2_FWNODE
>   help
>    Support for the Texas Instruments TVP5150 video decoder.
> 
> This made my build work again. But I am absolutely not sure this is the
> right fix or whether it is complete.

Yes, it is. There are other places where the same select is needed.

There's already a patch upstream (linux-next) addressing this issue.

It should be merged for 5.7.

Regards,
Mauro