linux-kernel - Re: [PATCH RFC v2 tip/core/rcu 01/22] sched/core: Add function to sample state of locked-down task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200320162731.GQ3199@paulmck-ThinkPad-P72>
Date:   Fri, 20 Mar 2020 09:27:31 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, mingo@...nel.org, jiangshanlai@...il.com,
        dipankar@...ibm.com, akpm@...ux-foundation.org,
        mathieu.desnoyers@...icios.com, josh@...htriplett.org,
        tglx@...utronix.de, peterz@...radead.org, dhowells@...hat.com,
        edumazet@...gle.com, fweisbec@...il.com, oleg@...hat.com,
        joel@...lfernandes.org, Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH RFC v2 tip/core/rcu 01/22] sched/core: Add function to
 sample state of locked-down task

On Thu, Mar 19, 2020 at 11:09:45PM -0400, Steven Rostedt wrote:
> On Thu, 19 Mar 2020 19:49:43 -0700
> "Paul E. McKenney" <paulmck@...nel.org> wrote:
> 
> > > The current setup is very convenient for the use cases thus far.  It
> > > allows the function to say "Yeah, I was called, but I couldn't do
> > > anything", thus allowing the caller to make exactly one check to know
> > > that corrective action is required.  
> > 
> > And here is another use case that led me to take this approach.
> > The trc_inspect_reader_notrunning() function in the patch below is passed
> > to try_invoke_on_locked_down_task() whose caller can continue testing
> > just the return value from try_invoke_on_locked_down_task() to work out
> > what to do next.
> > 
> > Thoughts?  Other use cases?
> 
> Note, I made this comment before looking at the use cases in the later
> patches. I was looking at it for a more generic purpose, but I'm not
> sure there is one.
> 
> It's fine as is for now.

Sounds good, and again thank you for looking this over!

							Thanx, Paul