linux-kernel - Re: [PATCH 1/2] iio: light: tsl2563: Wrap comment description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62965030-3cc8-78d3-ef80-f88c585f82e2@gmail.com>
Date:   Sat, 21 Mar 2020 18:40:16 +0530
From:   Nishant Malpani <nish.malpani25@...il.com>
To:     Joe Perches <joe@...ches.com>, jic23@...nel.org
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: light: tsl2563: Wrap comment description

On 21/03/20 5:21 pm, Joe Perches wrote:
> On Wed, 2020-03-18 at 13:33 +0530, Nishant Malpani wrote:
>> This patch wraps the comment description at 75 chars. Fixes the
>> following warning generated by checkpatch.pl:
>>
>> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> 
> Please do not scan files as patches.
> 
> checkpatch does not emit this message on a file
> when used properly with the -f option.
> 
You're right, Joe. I had used checkpatch.pl without the -f option on a 
file, ergo giving me the aforementioned warning. My bad, I shall refrain 
from not doing this in the future. Thank you and Jonathan for correcting me.

With regards,
Nishant Malpani

>> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> []
>> @@ -222,9 +222,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
>>   }
>>   
>>   /*
>> - * "Normalized" ADC value is one obtained with 400ms of integration time and
>> - * 16x gain. This function returns the number of bits of shift needed to
>> - * convert between normalized values and HW values obtained using given
>> + * "Normalized" ADC value is one obtained with 400ms of integration time
>> + * and 16x gain. This function returns the number of bits of shift needed
>> + * to convert between normalized values and HW values obtained using given
>>    * timing and gain settings.
>>    */
>>   static int tsl2563_adc_shiftbits(u8 timing)
>