linux-kernel - Re: [PATCH v5 3/9] x86/split_lock: Re-define the kernel param option for split_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200321004627.GC6578@agluck-desk2.amr.corp.intel.com>
Date:   Fri, 20 Mar 2020 17:46:27 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Xiaoyao Li <xiaoyao.li@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        hpa@...or.com, Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        kvm@...r.kernel.org, x86@...nel.org, linux-kernel@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Jim Mattson <jmattson@...gle.com>
Subject: Re: [PATCH v5 3/9] x86/split_lock: Re-define the kernel param option
 for split_lock_detect

On Sun, Mar 15, 2020 at 01:05:11PM +0800, Xiaoyao Li wrote:
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -4666,7 +4666,10 @@
>  			instructions that access data across cache line
>  			boundaries will result in an alignment check exception.
>  
> -			off	- not enabled
> +			disable	- disabled, neither kernel nor kvm can use it.

Are command line arguments "ABI"?  The "=off" variant isn't upstream yet,
but it is in TIP.  I'm ok with this change, but perhaps this patch (or at
least this part of this patch) needs to catch up with the older one within
the 5.7 merge window (or sometime before v5.7).

Reviewed-by: Tony Luck <tony.luck@...el.com>