linux-kernel - Re: [PATCH] irqchip: irq-imx-gpcv2: Remove unnecessary blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86mu89zqce.wl-maz@kernel.org>
Date:   Sat, 21 Mar 2020 15:21:05 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     tglx@...utronix.de, jason@...edaemon.net, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Linux-imx@....com
Subject: Re: [PATCH] irqchip: irq-imx-gpcv2: Remove unnecessary blank lines

On Tue, 17 Mar 2020 04:56:41 +0000,
Anson Huang <Anson.Huang@....com> wrote:
> 
> Remove unnecessary blank lines for cleanup.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>  drivers/irqchip/irq-imx-gpcv2.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 4f74c15..4f11b9b 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -17,7 +17,6 @@
>  #define GPC_IMR1_CORE2		0x1c0
>  #define GPC_IMR1_CORE3		0x1d0
>  
> -
>  struct gpcv2_irqchip_data {
>  	struct raw_spinlock	rlock;
>  	void __iomem		*gpc_base;
> @@ -287,6 +286,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>  	of_node_clear_flag(node, OF_POPULATED);
>  	return 0;
>  }
> -
>  IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
>  IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);

I honestly don't think this deserves a patch. Next time you work on
this driver, add the cleanups to it. But on its own, it's only churn.

Thanks,

	M.

-- 
Jazz is not dead, it just smells funny.