linux-kernel - Re: [PATCH v2 1/2] iio: adc: ad7291: convert to device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Veh3QRfqVFOpYbuuxcPqirc1_YrF-iZfRjNsYk7DWqYpQ@mail.gmail.com>
Date:   Sun, 22 Mar 2020 01:46:21 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Michael Auchter <michael.auchter@...com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Stefan Popa <stefan.popa@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: adc: ad7291: convert to device tree

On Tue, Mar 17, 2020 at 4:53 PM Michael Auchter <michael.auchter@...com> wrote:
>
> There are no in-tree users of the platform data for this driver, so
> remove it and convert the driver to use device tree instead.

...

> +       chip->reg = devm_regulator_get_optional(&client->dev, "vref");
> +       if (!IS_ERR(chip->reg)) {

Why not to go with usual positive conditional?

> +               ret = regulator_enable(chip->reg);
> +               if (ret)
> +                       return ret;
> +
>                 chip->command |= AD7291_EXT_REF;
> +       } else {
> +               if (PTR_ERR(chip->reg) != -ENODEV)
> +                       return PTR_ERR(chip->reg);
> +
> +               chip->reg = NULL;
> +       }

...

> +static const struct of_device_id ad7291_of_match[] = {
> +       { .compatible = "adi,ad7291", },

> +       {},

No need for comma.

> +};

...

> +               .of_match_table = of_match_ptr(ad7291_of_match),

No need to use of_match_ptr(). Haven't you got a compiler warning in !OF case?

-- 
With Best Regards,
Andy Shevchenko