linux-kernel - Re: [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYvoVF_q1Re_v_sJCYVDOhte0NpdU91UtYB2SpHH60-jg@mail.gmail.com>
Date:   Sun, 22 Mar 2020 12:45:29 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Sungbo Eo <mans0n@...ani.run>
Cc:     linux-oxnas@...ups.io, Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier

On Sat, Mar 21, 2020 at 2:40 PM Sungbo Eo <mans0n@...ani.run> wrote:

> Clear its own IRQs before the parent IRQ get enabled, so that the
> remaining IRQs do not accidentally interrupt the parent IRQ controller.
>
> This patch also fixes a reboot bug on OX820 SoC, where the remaining
> rps-timer IRQ raises a GIC interrupt that is left pending. After that,
> the rps-timer IRQ is cleared during driver initialization, and there's
> no IRQ left in rps-irq when local_irq_enable() is called, which evokes
> an error message "unexpected IRQ trap".
>
> Fixes: bdd272cbb97a ("irqchip: versatile FPGA: support cascaded interrupts from DT")
> Signed-off-by: Sungbo Eo <mans0n@...ani.run>
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Cc: Daniel Golle <daniel@...rotopia.org>

Good catch!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Marc: Cc stable?

Yours,
Linus Walleij