linux-kernel - Re: [PATCH v3] i2c: at91: support atomic write xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200322143004.GB1091@ninjato>
Date:   Sun, 22 Mar 2020 15:30:04 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Stefan Lengfeld <contact@...fanchrist.eu>,
        Marco Felsch <m.felsch@...gutronix.de>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: at91: support atomic write xfer


> +	/* FIXME: only single write request supported to 7-bit addr */

Hmm, this is quite limited. Would it be very hard to support multiple
messages? Or reads? 10 bits don't matter.

> +	if (!dev->pdata->has_alt_cmd)
> +		return -EOPNOTSUPP;

We should handle this in probe(), I think:

	if (dev->pdata->has_alt_cmd)
		at91_twi_algorithm.master_xfer_atomic = at91_twi_xfer_atomic;


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)