linux-kernel - Re: [PATCH] i2c: i801: Fix memory corruption in i801_isr_byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200322190813.39b92de2@endymion>
Date:   Sun, 22 Mar 2020 19:08:13 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Daniel Kurtz <djkurtz@...omium.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot <syzbot+ed71512d469895b5b34e@...kaller.appspotmail.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Subject: Re: [PATCH] i2c: i801: Fix memory corruption in
 i801_isr_byte_done()

Hi Wolfram,

Can you please bounce the previous messages in this thread to me? I was
apparently not Cc'd so I'm missing the context.

Thanks,
Jean

On Fri, 20 Mar 2020 15:57:48 +0100, Wolfram Sang wrote:
> On Sat, Feb 22, 2020 at 01:45:23PM +0100, Wolfram Sang wrote:
> > On Tue, Jan 14, 2020 at 10:34:06AM +0300, Dan Carpenter wrote:  
> > > Assigning "priv->data[-1] = priv->len;" obviously doesn't make sense.
> > > What it does is it ends up corrupting the last byte of priv->len so
> > > priv->len becomes a very high number.
> > > 
> > > Reported-by: syzbot+ed71512d469895b5b34e@...kaller.appspotmail.com
> > > Fixes: d3ff6ce40031 ("i2c-i801: Enable IRQ for byte_by_byte transactions")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > > ---  
> > 
> > Daniel, Jean: what do you think?
> > Also, adding Jarkko to CC who works a lot with this driver...  
> 
> Ping. Adding more people...
> 
> >   
> > > Untested.
> > > 
> > >  drivers/i2c/busses/i2c-i801.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> > > index f5e69fe56532..420d8025901e 100644
> > > --- a/drivers/i2c/busses/i2c-i801.c
> > > +++ b/drivers/i2c/busses/i2c-i801.c
> > > @@ -584,7 +584,6 @@ static void i801_isr_byte_done(struct i801_priv *priv)
> > >  					"SMBus block read size is %d\n",
> > >  					priv->len);
> > >  			}
> > > -			priv->data[-1] = priv->len;
> > >  		}
> > >  
> > >  		/* Read next byte */
> > > -- 
> > > 2.11.0
> > >