linux-kernel - Re: [PATCH] err.h: remove deprecated PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200322220438.2phluryjzno777w2@pengutronix.de>
Date:   Sun, 22 Mar 2020 23:04:38 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Gustavo A . R . Silva" <gustavo@...eddedor.com>,
        Nicholas Krause <xerofoify@...il.com>,
        Duan Jiong <duanj.fnst@...fujitsu.com>,
        Sachin Kamat <sachin.kamat@...aro.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] err.h: remove deprecated PTR_RET for good

On Sun, Mar 22, 2020 at 10:42:56PM +0100, Jiri Kosina wrote:
> On Sun, 22 Mar 2020, Lukas Bulwahn wrote:
> 
> > Initially, commit fa9ee9c4b988 ("include/linux/err.h: add a function to
> > cast error-pointers to a return value") from Uwe Kleine-König introduced
> > PTR_RET in 03/2011. Then, in 07/2013, commit 6e8b8726ad50 ("PTR_RET is
> > now PTR_ERR_OR_ZERO") from Rusty Russell renamed PTR_RET to
> > PTR_ERR_OR_ZERO, and left PTR_RET as deprecated-marked alias.
> > 
> > After six years since the renaming and various repeated cleanups in the
> > meantime, it is time to finally remove the deprecated PTR_RET for good.
> > 
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> > ---
> > Rusty, if you are still around, Acked-by is appreciated.
> > Uwe, Acked-by is appreciated.
> > Kudos to Gustavo, Nicholas, Duan & Sachin for previous cleanups.
> > 
> > applies cleanly on current master and on next-20200320
> > Jiri, please pick this trival patch for the next merge window. Thanks.
> 
> I am queuing it right away; it's been marked deprecated back in 2013, and 
> it doesn't have any in-tree users anyway.

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

in case it's not in a tree already that is not supposed to be changed
any more.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |