[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VcxJJ+GaLk7Rn5WveopZc76DkJA-dnB84QTpGfWdAbULA@mail.gmail.com>
Date: Mon, 23 Mar 2020 23:37:46 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Sergey Semin <Sergey.Semin@...kalelectronics.ru>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Hoan Tran <hoan@...amperecomputing.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Paul Burton <paulburton@...nel.org>,
Ralf Baechle <ralf@...ux-mips.org>,
"Enrico Weigelt, metux IT consult" <info@...ux.net>,
Allison Randal <allison@...utok.net>,
Kate Stewart <kstewart@...uxfoundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/6] gpio: dwapb: Add debounce reference clock support
On Mon, Mar 23, 2020 at 9:28 PM Sergey Semin
<Sergey.Semin@...kalelectronics.ru> wrote:
> On Mon, Mar 23, 2020 at 08:38:37PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 23, 2020 at 09:06:31PM +0300, Sergey.Semin@...kalelectronics.ru wrote:
> > > From: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > >
> > > Aside from the APB reference clock DW GPIO controller can have a
> > > dedicated clock connected to setup a debounce time interval for
> > > GPIO-based IRQs. Since this functionality is optional the corresponding
> > > clock source is also optional. Due to this lets handle the debounce
> > > clock in the same way as it has been developed for the APB reference
> > > clock, but using the bulk request/enable-disable methods.
> >
> > > + if (err) {
> > > + dev_err(gpio->dev, "Cannot reenable APB/Debounce clocks\n");
> > > + return err;
> > > + }
> >
> > Yeah, this should be a separate change.
> >
>
> Linus didn't think it was necessary in v1.
Ah, okay!
> > Otherwise looks good.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists