linux-kernel - Re: [Potential Spoof] [PATCH] mm: hugetlb: fix per-node size calculation for hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200323233601.GA30285@carbon.dhcp.thefacebook.com>
Date:   Mon, 23 Mar 2020 16:36:01 -0700
From:   Roman Gushchin <guro@...com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     Aslan Bakirov <aslan@...com>, Michal Hocko <mhocko@...nel.org>,
        <linux-mm@...ck.org>, <kernel-team@...com>,
        <linux-kernel@...r.kernel.org>, Rik van Riel <riel@...riel.com>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [Potential Spoof] [PATCH] mm: hugetlb: fix per-node size
 calculation for hugetlb_cma

On Mon, Mar 23, 2020 at 03:14:11PM -0700, Roman Gushchin wrote:
> Aslan found a bug in the per-node hugetlb_cma area size calculation:
> the total remaining size should cap the per-node area size instead
> of be the minimal possible allocation.
> 
> Without the fix:
> [    0.004136] hugetlb_cma: reserve 2048 MiB, up to 1024 MiB per node
> [    0.004138] cma: Reserved 2048 MiB at 0x0000000180000000
> [    0.004139] hugetlb_cma: reserved 2048 MiB on node 0
> 
> With the fix:
> [    0.006780] hugetlb_cma: reserve 2048 MiB, up to 1024 MiB per node
> [    0.006786] cma: Reserved 1024 MiB at 0x00000001c0000000
> [    0.006787] hugetlb_cma: reserved 1024 MiB on node 0
> [    0.006788] cma: Reserved 1024 MiB at 0x00000003c0000000
> [    0.006789] hugetlb_cma: reserved 1024 MiB on node 1
> 
> Reported-by: Aslan Barkirov <aslan@...com>
> Signed-off-by: Roman Gushchin <guro@...com>

I'm deeply sorry, I've made a typo in Aslan's name.

v2 fixes this.

Thanks!