linux-kernel - Re: [PATCH v4 2/2] mm/page_alloc: integrate classzone_idx and high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAmzW4O-c23H8ogAwhkM97GEeCKgxGtPx7v+csSTikEq7nH82A@mail.gmail.com>
Date:   Mon, 23 Mar 2020 14:58:15 +0900
From:   Joonsoo Kim <js1304@...il.com>
To:     Baoquan He <bhe@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Minchan Kim <minchan@...nel.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Mel Gorman <mgorman@...hsingularity.net>, kernel-team@....com,
        Ye Xiaolong <xiaolong.ye@...el.com>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH v4 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx

2020년 3월 23일 (월) 오후 2:40, Baoquan He <bhe@...hat.com>님이 작성:
> > > diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h
> > > index e5bf6ee..54e5bf0 100644
> > > --- a/include/trace/events/compaction.h
> > > +++ b/include/trace/events/compaction.h
> > > @@ -314,40 +314,44 @@ TRACE_EVENT(mm_compaction_kcompactd_sleep,
> > >
> > >  DECLARE_EVENT_CLASS(kcompactd_wake_template,
> > >
> > > -   TP_PROTO(int nid, int order, enum zone_type classzone_idx),
> > > +   TP_PROTO(int nid, int order, enum zone_type highest_zoneidx),
> > >
> > > -   TP_ARGS(nid, order, classzone_idx),
> > > +   TP_ARGS(nid, order, highest_zoneidx),
> > >
> > >     TP_STRUCT__entry(
> > >             __field(int, nid)
> > >             __field(int, order)
> > > -           __field(enum zone_type, classzone_idx)
> > > +           __field(enum zone_type, highest_zoneidx)
> > >     ),
> > >
> > >     TP_fast_assign(
> > >             __entry->nid = nid;
> > >             __entry->order = order;
> > > -           __entry->classzone_idx = classzone_idx;
> > > +           __entry->highest_zoneidx = highest_zoneidx;
> > >     ),
> > >
> > > +   /*
> > > +    * classzone_idx is previous name of the highest_zoneidx.
> > > +    * Reason not to change it is the ABI requirement of the tracepoint.
> > > +    */
> > >     TP_printk("nid=%d order=%d classzone_idx=%-8s",
> >                                  ~~~~~~~~~~ this one could be missed.
>
> Oh, I realized above 'classzone_idx=%-8s' being kept is for the old
> script compatibility? then it's OK.

Yes, this is for userspace compatibility. There are two places that aren't
changed due to compatibility and they are commented on top of the line.

Thanks.

> >
> > And I applied this patch series, use 'git grep classzone_idx' to search
> > any relics, found below classzone_idx leftover in perl script.
> > [~]$ git grep classzone_idx
> > Documentation/trace/postprocess/trace-vmscan-postprocess.pl:my $regex_lru_isolate_default = 'isolate_mode=([0-9]*) classzone_idx=([0-9]*) order=([0-9]*) nr_requested=([0-9]*) nr_scanned=([0-9]*) nr_skipped=([0-9]*) nr_taken=([0-9]*) lru=([a-z_]*)';
> > Documentation/trace/postprocess/trace-vmscan-postprocess.pl:                    "isolate_mode", "classzone_idx", "order",