linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Add Coresight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de3d226dbd7b00f9c4b7cd6c86db97e0@codeaurora.org>
Date:   Mon, 23 Mar 2020 13:07:55 +0530
From:   Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        devicetree@...r.kernel.org, Rajendra Nayak <rnayak@...eaurora.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Add Coresight support

On 2020-03-22 03:40, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2020-03-20 00:44:29)
>> Add coresight components found on Qualcomm SC7180 SoC.
>> 
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
>> ---
> 
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
> Tested-by: Stephen Boyd <swboyd@...omium.org>
> 
> One nit below.
> 
>>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 507 
>> +++++++++++++++++++++++++++
>>  1 file changed, 507 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 998f101ad623..d8fe960d6ace 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -1294,6 +1294,513 @@
>>                         };
>>                 };
>> 
>> +               stm@...2000 {
>> +                       compatible = "arm,coresight-stm", 
>> "arm,primecell";
>> +                       reg = <0 0x06002000 0 0x1000>,
>> +                             <0 0x16280000 0 0x180000>;
>> +                       reg-names = "stm-base", "stm-stimulus-base";
>> +
>> +                       clocks = <&aoss_qmp>;
>> +                       clock-names = "apb_pclk";
>> +
>> +                       out-ports {
>> +                               port {
>> +                                       stm_out: endpoint {
>> +                                               remote-endpoint =
>> +                                                 <&funnel0_in7>;
> 
> Given that this is DT I'd say we just put this remote-endpoint all on
> one line. Makes it more readable and I don't think we really care about
> the line length in these cases. We're nested pretty deep because it's a
> graph binding.
> 

Thanks for the review and test, I will make this change.

-Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation